Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable for-in lint rule #3013

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Enable for-in lint rule #3013

merged 3 commits into from
Dec 4, 2023

Conversation

jmrossy
Copy link
Contributor

@jmrossy jmrossy commented Dec 1, 2023

Description

https://eslint.org/docs/latest/rules/guard-for-in

Drive-by changes

Fix lint error in SDK Sealevel adapter

Backward compatibility

Yes

Fix lint error in SDK
Copy link

changeset-bot bot commented Dec 1, 2023

⚠️ No Changeset found

Latest commit: 0c786ee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jmrossy jmrossy merged commit eb83cf8 into main Dec 4, 2023
7 of 14 checks passed
@jmrossy jmrossy deleted the rossy/eslint-for-in-guard branch December 4, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants