Skip to content

changes for aca py 0.7.4 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Jul 1, 2022
Merged

changes for aca py 0.7.4 #18

merged 29 commits into from
Jul 1, 2022

Conversation

etschelp
Copy link
Contributor

@etschelp etschelp commented Apr 6, 2022

No description provided.

Philipp Etschel added 3 commits April 6, 2022 15:21
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
@etschelp etschelp marked this pull request as draft April 6, 2022 13:55
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
@swcurran
Copy link

swcurran commented Apr 6, 2022

So many files. Is this generated code? I see in the changes some are copyright dates and version updates -- but the page takes a long time to load :-)

I raise this because I'm wondering about the ACA-Py changes that drive this. Is the number of files changed reasonable, or did something happen between 0.7.3 and 0.7.4 that we should know about?

Thanks!

@ianco
Copy link
Contributor

ianco commented Apr 6, 2022

So many files. Is this generated code? I see in the changes some are copyright dates and version updates -- but the page takes a long time to load :-)

Looks like most of the changes are due to a line with a space in it (in a comment) is replaced with a line with no space :-D

I'm guessing a change to a template that is used to generate code.

@etschelp
Copy link
Contributor Author

etschelp commented Apr 6, 2022

Sorry for that. Yes, these are generated classes. I do not know where the space in the header is coming from, but from what is currently in the main branch there aren't any breaking changes in the api. The only api change so far is an additional "auto_verify" flag in the presentation exchanges. But as not everything is merged yet that might change.

Philipp Etschel added 22 commits April 14, 2022 14:36
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>

# Conflicts:
#	pom.xml
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
pmd
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>

# Conflicts:
#	src/main/java/org/hyperledger/aries/AriesClient.java
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>

# Conflicts:
#	src/main/java/org/hyperledger/aries/api/present_proof/PresentationExchangeRecord.java
#	src/main/java/org/hyperledger/aries/api/present_proof_v2/V20PresExRecord.java
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>

# Conflicts:
#	src/test/java/org/hyperledger/aries/api/multitenant/MultiTenantTest.java
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>

# Conflicts:
#	src/main/java/org/hyperledger/aries/AriesClient.java
#	src/test/java/org/hyperledger/aries/api/multitenant/MultiTenantTest.java
…etails.

Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
rc3
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
Philipp Etschel added 3 commits July 1, 2022 09:37
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
@etschelp etschelp marked this pull request as ready for review July 1, 2022 08:13
@etschelp etschelp merged commit af704b7 into main Jul 1, 2022
@etschelp etschelp deleted the feature/aca-py-0.7.4 branch July 1, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants