Skip to content

[#42] Add low level HTTP request tracing to the client #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tdiesler
Copy link
Contributor

Signed-off-by: Thomas Diesler tdiesler@redhat.com

Signed-off-by: Thomas Diesler <tdiesler@redhat.com>
@etschelp
Copy link
Contributor

etschelp commented Apr 26, 2022

This is not really needed because okhttp already has a solution for this see: https://github.com/square/okhttp/tree/master/okhttp-logging-interceptor

As the client supports passing a custom OkHttpClient, the interceptor can easily be injected without code changes. As others already do it this way your changes could potentially lead to duplicated output. But what we could do is add a default interceptor that uses slf4j and is set to trace, and redacts the headers. Like this no changes to the call() methods are needed.

@tdiesler
Copy link
Contributor Author

ok, great

@etschelp
Copy link
Contributor

replaced by: #46

@etschelp etschelp closed this Apr 26, 2022
@tdiesler tdiesler deleted the request-tracing branch May 19, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants