Skip to content
This repository was archived by the owner on Mar 27, 2024. It is now read-only.

feat: add verifiable controller mobile wrappers #2012

Merged
merged 1 commit into from
Jul 14, 2020
Merged

feat: add verifiable controller mobile wrappers #2012

merged 1 commit into from
Jul 14, 2020

Conversation

ToJen
Copy link

@ToJen ToJen commented Jul 14, 2020 •
edited
Loading

Signed-off-by: Tomisin Jenrola tomisin.jenrola@securekey.com

Title:
Added mobile binding wrappers for the Verifiable controller

Description:
Part of #1958
Part of #2005

Summary:

  1. Added Verifiable controller interface with local and remote agent implementations
  2. Added some documentation for Introduce, Verifiable and terminologies
  3. Update code snippet in README
  4. Added config options wrapper for Aries framework Option
  5. Other minor changes and cleanups

@codecov
Copy link

codecov bot commented Jul 14, 2020 •
edited
Loading

Codecov Report

Merging #2012 into master will not change coverage.
The diff coverage is 90.54%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2012   +/-   ##
=======================================
  Coverage   90.78%   90.78%           
=======================================
  Files         224      224           
  Lines       16922    16922           
=======================================
  Hits        15362    15362           
  Misses        922      922           
  Partials      638      638
Impacted Files Coverage Δ
pkg/controller/command/verifiable/command.go 88.65% <88.88%> (ø)
pkg/controller/rest/verifiable/operation.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bae8ca...21cf694. Read the comment docs.

talwinder50
talwinder50 reviewed Jul 14, 2020
View reviewed changes
talwinder50
talwinder50 reviewed Jul 14, 2020
View reviewed changes
@troyronda
Copy link
Contributor

@ToJen note verifiable isn't a "protocol"

troyronda
troyronda reviewed Jul 14, 2020
View reviewed changes
cmd/aries-agent-mobile/README.md
opts.useLocalAgent = true;

// create an aries agent instance
RestAriesREST *ac = (RestAriesREST*) AriesagentNewAriesAgent(opts, &error);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AriesagentNewAriesAgent ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is the result of the bindings for iOS. Everything gets prefixed with its package name and it can't be changed. However, Android doesn't have this issue. It's being tracked here: golang/go#32573 (comment)

llorllale
llorllale approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@llorllale llorllale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ToJen ToJen force-pushed the add_verifiable_protocol_wrappers branch from 0f2f61e to 712fc7c Compare July 14, 2020 15:50
@ToJen ToJen changed the title feat: add verifiable protocol mobile wrappers feat: add verifiable controller mobile wrappers Jul 14, 2020
feat: add verifiable controller mobile wrappers
21cf694 
Signed-off-by: Tomisin Jenrola <tomisin.jenrola@securekey.com>
@ToJen ToJen force-pushed the add_verifiable_protocol_wrappers branch from 712fc7c to 21cf694 Compare July 14, 2020 15:53
troyronda
troyronda reviewed Jul 14, 2020
View reviewed changes
cmd/aries-agent-mobile/main_test.go
"github.com/hyperledger/aries-framework-go/cmd/aries-agent-mobile/pkg/wrappers/command"
"github.com/hyperledger/aries-framework-go/cmd/aries-agent-mobile/pkg/wrappers/config"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these packages not under github.com/hyperledger/aries-framework-go/pkg ?

(followup)

@troyronda troyronda merged commit 574f37b into hyperledger-aries:master Jul 14, 2020
@ToJen ToJen mentioned this pull request Jul 17, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@troyronda troyronda troyronda left review comments

@llorllale llorllale llorllale approved these changes

@talwinder50 talwinder50 talwinder50 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ToJen @troyronda @llorllale @talwinder50