Skip to content

feat: allow connection invitation encoded in oob url param #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

genaris
Copy link
Contributor

@genaris genaris commented Sep 22, 2023

Closes #1581

Signed-off-by: Ariel Gentile <gentilester@gmail.com>
@genaris genaris requested a review from a team September 22, 2023 19:55
Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@codecov-commenter
Copy link

Codecov Report

Merging #1583 (610275b) into main (9732ce4) will decrease coverage by 0.01%.
The diff coverage is 88.00%.

@@            Coverage Diff             @@
##             main    #1583      +/-   ##
==========================================
- Coverage   85.73%   85.73%   -0.01%     
==========================================
  Files         950      950              
  Lines       22839    22838       -1     
  Branches     4010     4010              
==========================================
- Hits        19582    19580       -2     
- Misses       3072     3073       +1     
  Partials      185      185              
Files Changed Coverage Δ
packages/core/src/utils/parseInvitation.ts 75.32% <88.00%> (-1.60%) ⬇️

@genaris genaris merged commit 9d789fa into openwallet-foundation:main Sep 23, 2023
@genaris genaris deleted the feat/connection-invitation-in-oob-url-param branch September 23, 2023 11:37
auer-martin pushed a commit to auer-martin/aries-framework-javascript that referenced this pull request Nov 15, 2023
…t-foundation#1583)

Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
auer-martin pushed a commit to auer-martin/aries-framework-javascript that referenced this pull request Dec 4, 2023
…t-foundation#1583)

Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
genaris added a commit to genaris/credo-ts that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with Lissi OOB URLs
3 participants