[FAB-17307] InitRequired param check for ApproveForMyorg (#462)

This patch adds a check mechanism for the `InitRequired` parameter
for the chaincode definition of the current sequence number to
`ApproveForMyOrg`.

Signed-off-by: Tatsuya Sato <Tatsuya.Sato@hal.hitachi.com>

core/chaincode/lifecycle/lifecycle.go

@@ -114,6 +114,8 @@ func (cp *ChaincodeParameters) Equal(ocp *ChaincodeParameters) error {
 		return errors.Errorf("Version '%s' != '%s'", cp.EndorsementInfo.Version, ocp.EndorsementInfo.Version)
 	case cp.EndorsementInfo.EndorsementPlugin != ocp.EndorsementInfo.EndorsementPlugin:
 		return errors.Errorf("EndorsementPlugin '%s' != '%s'", cp.EndorsementInfo.EndorsementPlugin, ocp.EndorsementInfo.EndorsementPlugin)
+	case cp.EndorsementInfo.InitRequired != ocp.EndorsementInfo.InitRequired:
+		return errors.Errorf("InitRequired '%t' != '%t'", cp.EndorsementInfo.InitRequired, ocp.EndorsementInfo.InitRequired)
 	case cp.ValidationInfo.ValidationPlugin != ocp.ValidationInfo.ValidationPlugin:
 		return errors.Errorf("ValidationPlugin '%s' != '%s'", cp.ValidationInfo.ValidationPlugin, ocp.ValidationInfo.ValidationPlugin)
 	case !bytes.Equal(cp.ValidationInfo.ValidationParameter, ocp.ValidationInfo.ValidationParameter):

core/chaincode/lifecycle/lifecycle_test.go

@@ -59,6 +59,16 @@ var _ = Describe("ChaincodeParameters", func() {
 			})
 		})
 
+		Context("when the InitRequired differs from the current definition", func() {
+			BeforeEach(func() {
+				rhs.EndorsementInfo.InitRequired = true
+			})
+
+			It("returns an error", func() {
+				Expect(lhs.Equal(rhs)).To(MatchError("InitRequired 'false' != 'true'"))
+			})
+		})
+
 		Context("when the ValidationPlugin differs from the current definition", func() {
 			BeforeEach(func() {
 				rhs.ValidationInfo.ValidationPlugin = "different"