[FAB-17307] InitRequired param check for ApproveForMyorg #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a check mechanism for the `InitRequired` parameter for the chaincode definition of the current sequence number to `ApproveForMyOrg`. Signed-off-by: Tatsuya Sato <Tatsuya.Sato@hal.hitachi.com>
|
jyellick
approved these changes
Jan 8, 2020
|
Thanks for finding and fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a check mechanism for the
InitRequiredparameter for the chaincode definition of the current sequence number toApproveForMyOrg.Type of change
Description
ApproveForMyOrg puts a chaincode definition entry for either the currently defined sequence number or the next sequence number.
According to comments on the current implementation, for the definition of the current sequence number (which means it has been committed), this command should reject the requested definition unless the requested one must match exactly the current one.
However, the current ApproveForMyOrg command does not check the InitRequired parameter, so the operators can update the InitRequired parameter.
When an organization does this update, it returns the chaincode to unapproved status for the organization.
To fix the bug, it is necessary to add a check mechanism for the InitRequired parameter to ApproveForMyOrg.
Related issues
https://jira.hyperledger.org/browse/FAB-17307