Use codecov github action #1526
Conversation
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
|
This still doesn't work, will come back to it |
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
| - uses: codecov/codecov-action@v4 | ||
| with: | ||
| codecov_yml_path: ./codecov.yml | ||
| token: ${{ secrets.CODECOV_TOKEN }} |
There was a problem hiding this comment.
I'm not sure we've set up codecov tokens on other repos in HL previously.
I think this PR is pointing out that codecov is trying to deprecate the ability to use it without a token, and as such we might need one.
That might need a conversation with the HL team potentially, as while I believe the free tier would be fine still on codecov.io, there would need to be a user that could own the github account that is associated with the token.
There was a problem hiding this comment.
The repo has a secret CODECOV_TOKEN set for the Github Action to use and the previous bash step used the token already. I have no idea who/how that token ended up in the repository, doesn't seem to be a HL thing based on not seeing anything on discord. The reality is that the token probably expired at some point in the last few months. I do wonder how we created an account against codecov and generated a token, and what email/credentials we used.
There was a problem hiding this comment.
@peterbroadhurst this is the original PR https://github.com/hyperledger/firefly/pull/8/files
There was a problem hiding this comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1526 +/- ##
===========================================
+ Coverage 99.97% 100.00% +0.02%
===========================================
Files 323 324 +1
Lines 23537 23645 +108
===========================================
+ Hits 23530 23645 +115
+ Misses 5 0 -5
+ Partials 2 0 -2 ☔ View full report in Codecov by Sentry. |
|
This now worked https://app.codecov.io/github/hyperledger/firefly/commit/582db4c8814f471d9df0b2c8df30de20f9862dc7 @ryjones changed the token inside the repo with a Hyperledger CodeCov token and gave me access to CodeCov as well |
|
Super, thanks @EnriqueL8 and @ryjones |
Move to using the GitHub action as the bash script is not using the token correctly