Fix issues that allow use of asserts in hyperlight_host release builds #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
simongdavies
requested review from
danbugs,
ludfjig,
dblnz,
devigned,
syntactically,
marosset and
jprendes
as code owners
simongdavies
changed the title
simongdavies
added
kind/enhancement
marosset
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clippy lints that enforce the prevention of use of asserts in release code do not work correctly in hyperlight_host.
There are a couple of issues:
clippy.toml was not in the correct location so the disallow of the assert* macros was not being enforced in hyperlight_host.
After moving clippy.toml to the correct location the lints started to fail as there are asserts in the integration tests and examples that were not being excluded from the linting rules.
There was a case of an assert! in the windows hypervisor implementation.
With this change the prevention of asserts is enforced correctly