Remove duplicate derive Clone in macro #620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprendes
requested review from
danbugs,
ludfjig,
dblnz,
devigned,
syntactically,
marosset and
simongdavies
as code owners
simongdavies
previously approved these changes
Jun 13, 2025
jprendes
force-pushed
the
fix-double-clone
branch
from
45cbba8 to
56cee55
Compare
jprendes
force-pushed
the
fix-double-clone
branch
from
653152c to
6c301e3
Compare
simongdavies
approved these changes
Jun 13, 2025
jprendes
force-pushed
the
fix-double-clone
branch
from
6c301e3 to
d7ea2e3
Compare
dblnz
approved these changes
Jun 13, 2025
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
jprendes
force-pushed
the
fix-double-clone
branch
from
d7ea2e3 to
26a9282
Compare
marosset
pushed a commit
to marosset/hyperlight
that referenced
this pull request
Jun 13, 2025
* Remove duplicate derive Clone in macro Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com> * Make rust-analyzer happy when evaluating the component macros Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com> * bump Cargo.lock files Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com> --------- Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
marosset
added a commit
that referenced
this pull request
Jun 13, 2025
* Remove duplicate derive Clone in macro * Make rust-analyzer happy when evaluating the component macros * bump Cargo.lock files --------- Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com> Co-authored-by: Jorge Prendes <jorge.prendes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a duplicated
derive(Clone)inhyperlight-component-utilthat result in a compilation error when using thewasm_guest_bindgenmacro fromhyperlight-wasm.Clone is already being derived in L. 483