[fix] Make sure mmaped memory is not mapped writeable into sandbox in kvm #740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludfjig
requested review from
danbugs,
dblnz,
devigned,
syntactically,
marosset,
jprendes and
simongdavies
as code owners
ludfjig
changed the title
ludfjig
force-pushed
the
kvm_mmap_permission
branch
5 times, most recently
from
cebf884 to
8e437c1
Compare
simongdavies
previously approved these changes
Jul 30, 2025
syntactically
previously approved these changes
Jul 30, 2025
ludfjig
force-pushed
the
kvm_mmap_permission
branch
from
8e437c1 to
0124549
Compare
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
ludfjig
force-pushed
the
kvm_mmap_permission
branch
from
0124549 to
0833407
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writes into mmaped regions was accidentally possible on kvm.
KVM_MEM_READONLY was confirmed to be RX by testing hyperlight-wasm on this commit, which worked fine. EDIT: Now also tested in test here
Also adds a test which would currently fail, but now passes