fix(guest-bin): move logger initialization #755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not run any complex tasks until the global allocator is initialized. Signed-off-by: Tomasz Andrzejak <andreiltd@gmail.com>
andreiltd
requested review from
danbugs,
ludfjig,
dblnz,
devigned,
syntactically,
marosset,
jprendes and
simongdavies
as code owners
andreiltd
added
the
kind/enhancement
andreiltd
changed the title
ludfjig
approved these changes
Jul 31, 2025
danbugs
approved these changes
Aug 1, 2025
Oh I didn't run into any specific issue with this code. I just thought it was sketchy to run logger initialization without initializing allocator first. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not run any complex tasks until the global allocator is initialized.