Skip to content

Remove serial testing #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2025
Merged

Remove serial testing #878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 0 additions & 57 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion src/hyperlight_host/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ proptest = "1.7.0"
tempfile = "3.22.0"
crossbeam-queue = "0.3.12"
tracing-serde = "0.2.0"
serial_test = "3.1.1"
hyperlight-testing = { workspace = true }
env_logger = "0.11.8"
tracing-forest = { version = "0.2.0", features = ["uuid", "chrono", "smallvec", "serde", "env-filter"] }
Expand Down
2 changes: 0 additions & 2 deletions src/hyperlight_host/src/hypervisor/surrogate_process_manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,6 @@ mod tests {

use hyperlight_common::mem::PAGE_SIZE_USIZE;
use rand::{Rng, rng};
use serial_test::serial;
use windows::Win32::Foundation::{CloseHandle, HANDLE, INVALID_HANDLE_VALUE};
use windows::Win32::System::Diagnostics::ToolHelp::{
CreateToolhelp32Snapshot, PROCESSENTRY32, Process32First, Process32Next, TH32CS_SNAPPROCESS,
Expand All @@ -437,7 +436,6 @@ mod tests {
use super::*;
use crate::mem::shared_mem::{ExclusiveSharedMemory, SharedMemory};
#[test]
#[serial]
fn test_surrogate_process_manager() {
let mut threads = Vec::new();
// create more threads than surrogate processes as we want to test that
Expand Down
15 changes: 0 additions & 15 deletions src/hyperlight_host/tests/sandbox_host_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,11 @@ use hyperlight_host::{
GuestBinary, HyperlightError, MultiUseSandbox, Result, UninitializedSandbox, new_error,
};
use hyperlight_testing::simple_guest_as_string;
#[cfg(target_os = "windows")]
use serial_test::serial; // using LoadLibrary requires serial tests

pub mod common; // pub to disable dead_code warning
use crate::common::get_simpleguest_sandboxes;

#[test]
#[cfg_attr(target_os = "windows", serial)] // using LoadLibrary requires serial tests
fn pass_byte_array() {
for mut sandbox in get_simpleguest_sandboxes(None).into_iter() {
const LEN: usize = 10;
Expand All @@ -49,7 +46,6 @@ fn pass_byte_array() {

#[test]
#[ignore = "Fails with mismatched float only when c .exe guest?!"]
#[cfg_attr(target_os = "windows", serial)] // using LoadLibrary requires serial tests
fn float_roundtrip() {
let doubles = [
0.0,
Expand Down Expand Up @@ -107,7 +103,6 @@ fn float_roundtrip() {
}

#[test]
#[cfg_attr(target_os = "windows", serial)] // using LoadLibrary requires serial tests
fn invalid_guest_function_name() {
for mut sandbox in get_simpleguest_sandboxes(None).into_iter() {
let fn_name = "FunctionDoesntExist";
Expand All @@ -120,7 +115,6 @@ fn invalid_guest_function_name() {
}

#[test]
#[cfg_attr(target_os = "windows", serial)] // using LoadLibrary requires serial tests
fn set_static() {
for mut sandbox in get_simpleguest_sandboxes(None).into_iter() {
let fn_name = "SetStatic";
Expand All @@ -133,7 +127,6 @@ fn set_static() {
}

#[test]
#[cfg_attr(target_os = "windows", serial)] // using LoadLibrary requires serial tests
fn multiple_parameters() {
let (tx, rx) = channel();
let writer = move |msg: String| {
Expand Down Expand Up @@ -181,7 +174,6 @@ fn multiple_parameters() {
}

#[test]
#[cfg_attr(target_os = "windows", serial)] // using LoadLibrary requires serial tests
fn incorrect_parameter_type() {
for mut sandbox in get_simpleguest_sandboxes(None) {
let res = sandbox.call::<i32>(
Expand All @@ -199,7 +191,6 @@ fn incorrect_parameter_type() {
}

#[test]
#[cfg_attr(target_os = "windows", serial)] // using LoadLibrary requires serial tests
fn incorrect_parameter_num() {
for mut sandbox in get_simpleguest_sandboxes(None).into_iter() {
let res = sandbox.call::<i32>("Echo", ("1".to_string(), 2_i32));
Expand Down Expand Up @@ -229,7 +220,6 @@ fn max_memory_sandbox() {
}

#[test]
#[cfg_attr(target_os = "windows", serial)] // using LoadLibrary requires serial tests
fn iostack_is_working() {
for mut sandbox in get_simpleguest_sandboxes(None).into_iter() {
let res: i32 = sandbox
Expand Down Expand Up @@ -290,13 +280,11 @@ fn simple_test_helper() -> Result<()> {
}

#[test]
#[cfg_attr(target_os = "windows", serial)] // using LoadLibrary requires serial tests
fn simple_test() {
simple_test_helper().unwrap();
}

#[test]
#[cfg(target_os = "linux")]
fn simple_test_parallel() {
let handles: Vec<_> = (0..50)
.map(|_| {
Expand Down Expand Up @@ -333,13 +321,11 @@ fn callback_test_helper() -> Result<()> {
}

#[test]
#[cfg_attr(target_os = "windows", serial)] // using LoadLibrary requires serial tests
fn callback_test() {
callback_test_helper().unwrap();
}

#[test]
#[cfg(target_os = "linux")] // windows can't run parallel with LoadLibrary
fn callback_test_parallel() {
let handles: Vec<_> = (0..100)
.map(|_| {
Expand All @@ -355,7 +341,6 @@ fn callback_test_parallel() {
}

#[test]
#[cfg_attr(target_os = "windows", serial)] // using LoadLibrary requires serial tests
fn host_function_error() -> Result<()> {
for mut sandbox in get_uninit_simpleguest_sandboxes(None).into_iter() {
// create host function
Expand Down
Loading