Skip to content

Add missing clippy checks to clippy-exhaustive just target #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
Merged

Add missing clippy checks to clippy-exhaustive just target #890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,10 @@ clippy-exhaustive target=default-target: (witguest-wit)
./hack/clippy-package-features.sh hyperlight-guest-bin {{ target }}
./hack/clippy-package-features.sh hyperlight-common {{ target }}
./hack/clippy-package-features.sh hyperlight-testing {{ target }}
./hack/clippy-package-features.sh hyperlight-component-macro {{ target }}
./hack/clippy-package-features.sh hyperlight-component-util {{ target }}
./hack/clippy-package-features.sh hyperlight-guest-tracing-macro {{ target }}
./hack/clippy-package-features.sh hyperlight-guest-tracing {{ target }}
just clippy-guests {{ target }}

# Test a specific package with all feature combinations
Expand All @@ -268,7 +272,7 @@ clippy-package package target=default-target: (witguest-wit)

# Verify Minimum Supported Rust Version
verify-msrv:
./dev/verify-msrv.sh hyperlight-host hyperlight-guest hyperlight-guest-lib hyperlight-common
./dev/verify-msrv.sh hyperlight-common hyperlight-guest hyperlight-guest-bin hyperlight-host hyperlight-component-util hyperlight-component-macro hyperlight-guest-tracing-macro hyperlight-guest-tracing

#####################
### RUST EXAMPLES ###
Expand Down
2 changes: 1 addition & 1 deletion src/hyperlight_guest_tracing/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ mod trace {
#[test]
fn test_trace_record_creation_valid() {
let msg = "Valid message";
let entry = TraceRecord::try_from(msg).expect("Failed to create TraceRecord");
let entry = TraceRecord::from(msg);
assert_eq!(entry.msg_len, msg.len());
assert_eq!(&entry.msg[..msg.len()], msg.as_bytes());
assert!(entry.cycles > 0); // Ensure cycles is set
Expand Down
Loading