-
Notifications
You must be signed in to change notification settings - Fork 149
Fix unused import error in nightly musl clippy exhaustive check #948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The import on line 664 was redundant as ErrorCode is already imported at module level on line 31. When the seccomp feature is disabled (as in musl target tests), this local import becomes unused and causes clippy to fail with -D warnings. Signed-off-by: GitHub Copilot <copilot@github.com> Co-authored-by: jsturtevant <648372+jsturtevant@users.noreply.github.com>
@copilot rebase and run |
Rebased onto latest main (036d3ae) and verified with The test failures are expected due to missing hypervisor in the sandboxed environment ("No Hypervisor was found for Sandbox"), but the critical clippy verification completed successfully with the fix. Commit: 78427ba Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Bumps [wasmparser](https://github.com/bytecodealliance/wasm-tools) from 0.239.0 to 0.240.0. - [Release notes](https://github.com/bytecodealliance/wasm-tools/releases) - [Commits](https://github.com/bytecodealliance/wasm-tools/commits) --- updated-dependencies: - dependency-name: wasmparser dependency-version: 0.240.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [windows](https://github.com/microsoft/windows-rs) from 0.62.1 to 0.62.2. - [Release notes](https://github.com/microsoft/windows-rs/releases) - [Commits](https://github.com/microsoft/windows-rs/commits) --- updated-dependencies: - dependency-name: windows dependency-version: 0.62.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jsturtevant <648372+jsturtevant@users.noreply.github.com>
Fix unused import error in nightly musl clippy exhaustive check
initialized_multi_use.rs
ErrorCode
within a test functionjust target-triple=x86_64-unknown-linux-musl like-ci debug
- all clippy checks passedSummary
Fixed the nightly musl clippy failure by removing a redundant local import of
ErrorCode
in thetest_violate_seccomp_filters
test function. The import was already available at module level (line 31), making the local import on line 664 unnecessary. When theseccomp
feature is disabled (as in musl target tests), this local import becomes unused and causes clippy to fail with-D warnings
.The fix has been verified with multiple feature combinations including the full
clippy-exhaustive
check with musl target.Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.