Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Oct 9, 2025

Fix unused import error in nightly musl clippy exhaustive check

  • Identified the issue: unused import on line 664 of initialized_multi_use.rs
  • Analyzed the problem: redundant local import of ErrorCode within a test function
  • Removed the redundant local import (ErrorCode is already imported at module level on line 31)
  • Verified the fix locally with clippy (tested with multiple feature combinations)
  • Rebased onto latest main
  • Verified with just target-triple=x86_64-unknown-linux-musl like-ci debug - all clippy checks passed

Summary

Fixed the nightly musl clippy failure by removing a redundant local import of ErrorCode in the test_violate_seccomp_filters test function. The import was already available at module level (line 31), making the local import on line 664 unnecessary. When the seccomp feature is disabled (as in musl target tests), this local import becomes unused and causes clippy to fail with -D warnings.

The fix has been verified with multiple feature combinations including the full clippy-exhaustive check with musl target.

Original prompt

This section details on the original issue you should resolve

<issue_title>Nightly musl Failure - 9</issue_title>
<issue_description>## Job Failure Report

Date: 2025-10-09 00:37:02 UTC
Workflow Run: https://github.com/hyperlight-dev/hyperlight/actions/runs/18361523373

Details

The scheduled job failed during execution. This issue was automatically created to track the failure. Please check the workflow logs and any uploaded artifacts for more details.

Next Steps

  • Review the workflow logs for error details
  • Download and analyze any crash artifacts if available
  • Determine the root cause of the failure
  • Fix the underlying issue

This issue was automatically created by the CI failure notification system.</issue_description>

Comments on the Issue (you are @copilot in this section)

@jsturtevant Looks like a clippy issue
|
664 |         use hyperlight_common::flatbuffer_wrappers::guest_error::ErrorCode;
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `-D unused-imports` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(unused_imports)]`

error: could not compile `hyperlight-host` (lib test) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
error: Recipe `clippy-exhaustive` failed on line 271 with exit code 101
Error
```</body></comment_new>
</comments>

Fixes #947

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

The import on line 664 was redundant as ErrorCode is already imported at module level on line 31. When the seccomp feature is disabled (as in musl target tests), this local import becomes unused and causes clippy to fail with -D warnings.

Signed-off-by: GitHub Copilot <copilot@github.com>

Co-authored-by: jsturtevant <648372+jsturtevant@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] Fix nightly job execution failure in CI pipeline Fix unused import error in nightly musl clippy exhaustive check Oct 9, 2025
@Copilot Copilot AI requested a review from jsturtevant October 9, 2025 02:01
Copilot finished work on behalf of jsturtevant October 9, 2025 02:01
@jsturtevant jsturtevant added the kind/bugfix For PRs that fix bugs label Oct 10, 2025
@jsturtevant
Copy link
Contributor

@copilot rebase and run just target-triple=x86_64-unknown-linux-musl like-ci debug to verify

Copy link
Contributor Author

Copilot AI commented Oct 10, 2025

@copilot rebase and run just target-triple=x86_64-unknown-linux-musl like-ci debug to verify

Rebased onto latest main (036d3ae) and verified with just target-triple=x86_64-unknown-linux-musl like-ci debug. All clippy checks passed successfully, including the clippy-exhaustive check that was failing before.

The test failures are expected due to missing hypervisor in the sandboxed environment ("No Hypervisor was found for Sandbox"), but the critical clippy verification completed successfully with the fix.

Commit: 78427ba

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/cross-rs/cross/commits/HEAD
    • Triggering command: /home/REDACTED/.rustup/toolchains/1.89-x86_64-REDACTED-linux-gnu/bin/cargo install cross --git REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

dependabot bot and others added 5 commits October 10, 2025 01:40
Bumps [wasmparser](https://github.com/bytecodealliance/wasm-tools) from 0.239.0 to 0.240.0.
- [Release notes](https://github.com/bytecodealliance/wasm-tools/releases)
- [Commits](https://github.com/bytecodealliance/wasm-tools/commits)

---
updated-dependencies:
- dependency-name: wasmparser
  dependency-version: 0.240.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [windows](https://github.com/microsoft/windows-rs) from 0.62.1 to 0.62.2.
- [Release notes](https://github.com/microsoft/windows-rs/releases)
- [Commits](https://github.com/microsoft/windows-rs/commits)

---
updated-dependencies:
- dependency-name: windows
  dependency-version: 0.62.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…cbytes (#950)

- Add Tests for CAPI Flatbuffers
- Separate function for creating Uninitialized Sandbox for C guests
- Ignore Test cases for float and double until Github issue #179 is fixed.

Signed-off-by: Shailesh Vashishth <shavashishth@gmail.com>
Co-authored-by: jsturtevant <648372+jsturtevant@users.noreply.github.com>
Copilot finished work on behalf of jsturtevant October 10, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bugfix For PRs that fix bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nightly musl Failure - 9

3 participants