Skip to content

Conversation

aaron-steinfeld
Copy link
Contributor

Description

Updates to bring in latest version of hyperdash, and exposes a new feature - support for custom deserializers. Also includes bugfix for variable reference tracking cleanup on model destroy.

Testing

Unit tests, visual verification

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

also includes bugfix for variable reference tracking cleanup on model
destroy
@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner February 1, 2021 23:58
@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #158 (de38468) into main (387af69) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #158   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        49    +1     
  Lines          651       655    +4     
  Branches        61        64    +3     
=========================================
+ Hits           651       655    +4     
Impacted Files Coverage Δ
...src/configuration/default-configuration.service.ts 100.00% <100.00%> (ø)
...e-wrappers/before-model-destroyed-event.service.ts 100.00% <100.00%> (ø)
...r/src/injectable-wrappers/model-manager.service.ts 100.00% <100.00%> (ø)
...rc/injectable-wrappers/variable-manager.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 387af69...8e06775. Read the comment docs.

@github-actions

This comment has been minimized.

@aaron-steinfeld aaron-steinfeld merged commit f592f3a into main Feb 2, 2021
@aaron-steinfeld aaron-steinfeld deleted the update-hyperdash branch February 2, 2021 01:25
@github-actions
Copy link

github-actions bot commented Feb 2, 2021

Unit Test Results

  2 files  ±0  15 suites  ±0   19s ⏱️ ±0s
53 tests  - 2  53 ✔️  - 2  0 💤 ±0  0 ❌ ±0 

Results for commit f592f3a. ± Comparison against base commit 387af69.

@github-actions
Copy link

github-actions bot commented Feb 2, 2021

🎉 This PR is included in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants