Skip to content

fix: new design for not found page #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 27, 2021
Merged

Conversation

alok-traceable
Copy link
Contributor

@alok-traceable alok-traceable commented Jul 26, 2021

Description

Changes for new NOT FOUND page.

Testing

No changes on the existing test cases

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Before
Screen Shot 2021-07-26 at 11 14 41 AM

After
Screen Shot 2021-07-26 at 11 13 34 AM

@alok-traceable alok-traceable requested a review from a team as a code owner July 26, 2021 03:15
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #1022 (416c64f) into main (b7d4569) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1022   +/-   ##
=======================================
  Coverage   85.06%   85.06%           
=======================================
  Files         820      820           
  Lines       16863    16863           
  Branches     2190     2190           
=======================================
  Hits        14344    14344           
  Misses       2488     2488           
  Partials       31       31           
Impacted Files Coverage Δ
...ts/components/src/not-found/not-found.component.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7d4569...416c64f. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@alok-traceable alok-traceable merged commit c90b652 into main Jul 27, 2021
@alok-traceable alok-traceable deleted the not_found_page_design_change branch July 27, 2021 03:28
@github-actions
Copy link

Unit Test Results

    4 files  ±0  262 suites  ±0   16m 7s ⏱️ - 1m 0s
945 tests ±0  945 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
952 runs  ±0  952 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c90b652. ± Comparison against base commit b7d4569.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants