Skip to content

feat: removing unused type in tickCount variable #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2021

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented Aug 2, 2021

Description

Removing unused type in tickCount variable

Testing

Visual testing.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from a team as a code owner August 2, 2021 22:53
@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #1048 (f13d109) into main (a362318) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1048   +/-   ##
=======================================
  Coverage   85.07%   85.07%           
=======================================
  Files         822      822           
  Lines       16923    16923           
  Branches     2045     2045           
=======================================
  Hits        14398    14398           
  Misses       2494     2494           
  Partials       31       31           
Impacted Files Coverage Δ
...rvability/src/shared/components/cartesian/chart.ts 100.00% <ø> (ø)
...red/components/cartesian/d3/axis/cartesian-axis.ts 80.70% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a362318...f13d109. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@palbizu palbizu merged commit 2863c9e into main Aug 2, 2021
@palbizu palbizu deleted the AdjustingTickCountType branch August 2, 2021 22:59
@github-actions
Copy link

github-actions bot commented Aug 2, 2021

Unit Test Results

    4 files  ±0  263 suites  ±0   14m 57s ⏱️ -22s
947 tests ±0  947 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
954 runs  ±0  954 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2863c9e. ± Comparison against base commit a362318.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants