Skip to content

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented Aug 13, 2021

Description

  • Adding border property to icons and select

Testing

Visual testing

image

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from a team as a code owner August 13, 2021 17:32
@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #1063 (70c0795) into main (f8d8b7c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1063   +/-   ##
=======================================
  Coverage   85.08%   85.08%           
=======================================
  Files         822      822           
  Lines       16924    16931    +7     
  Branches     2045     2045           
=======================================
+ Hits        14399    14406    +7     
  Misses       2494     2494           
  Partials       31       31           
Impacted Files Coverage Δ
projects/components/src/select/select.component.ts 95.38% <ø> (ø)
projects/components/src/icon/icon.component.ts 86.48% <100.00%> (+1.19%) ⬆️
projects/components/src/public-api.ts 100.00% <100.00%> (ø)
...s/components/src/select/select-option.component.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8d8b7c...70c0795. Read the comment docs.

@github-actions

This comment has been minimized.

jake-bassett
jake-bassett previously approved these changes Aug 16, 2021
@jake-bassett
Copy link
Contributor

One thing we may want to tweak is whether the border is inset or outset. Outset is fine for now, but may want to switch to inset or make it configurable.

@palbizu palbizu requested a review from jake-bassett August 17, 2021 16:21
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@palbizu palbizu merged commit 4ee6013 into main Aug 17, 2021
@palbizu palbizu deleted the AddingBorderProperties branch August 17, 2021 22:19
@github-actions
Copy link

Unit Test Results

    4 files  ±0  263 suites  ±0   15m 35s ⏱️ +18s
947 tests ±0  947 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
954 runs  ±0  954 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4ee6013. ± Comparison against base commit f8d8b7c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants