Skip to content

Conversation

aaron-steinfeld
Copy link
Contributor

Description

This change removes the knowledge of other services from navigation service, allowing them to register global query params (rather than hardcoding them) for a more decoupled design.

Testing

Updated and added new unit tests

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner January 27, 2021 21:18
@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #538 (62bf9f8) into main (bd4d0b3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #538   +/-   ##
=======================================
  Coverage   85.60%   85.60%           
=======================================
  Files         759      759           
  Lines       15545    15549    +4     
  Branches     1842     1842           
=======================================
+ Hits        13307    13311    +4     
  Misses       2207     2207           
  Partials       31       31           
Impacted Files Coverage Δ
...ojects/common/src/navigation/navigation.service.ts 92.38% <100.00%> (+0.22%) ⬆️
projects/common/src/time/time-range.service.ts 83.33% <100.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd4d0b3...62bf9f8. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@aaron-steinfeld aaron-steinfeld merged commit dbfcf24 into main Jan 27, 2021
@aaron-steinfeld aaron-steinfeld deleted the global-query-params branch January 27, 2021 22:57
@github-actions
Copy link

Unit Test Results

    4 files  ±0  232 suites  ±0   12m 48s ⏱️ - 1m 58s
822 tests +1  822 ✔️ +1  0 💤 ±0  0 ❌ ±0 
826 runs  +1  826 ✔️ +1  0 💤 ±0  0 ❌ ±0 

Results for commit dbfcf24. ± Comparison against base commit bd4d0b3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants