Skip to content

Conversation

palbizu
Copy link
Contributor

@palbizu palbizu commented Apr 19, 2021

Description

  • Adding rows count feature to Textarea component.
  • Adding minHeight feature to Textarea component.

Testing

Visual Testing

Old:

image

New:

image

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@palbizu palbizu requested a review from a team as a code owner April 19, 2021 22:09
@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #785 (c92b82a) into main (55bc7d4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #785   +/-   ##
=======================================
  Coverage   85.40%   85.40%           
=======================================
  Files         791      791           
  Lines       16155    16156    +1     
  Branches     2060     2060           
=======================================
+ Hits        13797    13798    +1     
  Misses       2327     2327           
  Partials       31       31           
Impacted Files Coverage Δ
...ects/components/src/textarea/textarea.component.ts 80.00% <100.00%> (+1.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55bc7d4...c92b82a. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@palbizu palbizu requested a review from aaron-steinfeld April 19, 2021 22:40
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@palbizu palbizu requested a review from aaron-steinfeld April 20, 2021 15:32
@github-actions

This comment has been minimized.

@aaron-steinfeld
Copy link
Contributor

So my main goal here is that we can style our component in the same way we'd style the text area if we were using it directly. Inheriting individual properties is a bit brittle, but if we can't come up with a better way I think it's better than the input.

@github-actions

This comment has been minimized.

@palbizu palbizu merged commit 6deb3bf into main Apr 20, 2021
@palbizu palbizu deleted the RowsCountInTextarea branch April 20, 2021 19:53
@github-actions
Copy link

Unit Test Results

    4 files  249 suites   14m 9s ⏱️
893 tests 893 ✔️ 0 💤 0 ❌
899 runs  899 ✔️ 0 💤 0 ❌

Results for commit 6deb3bf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants