-
Notifications
You must be signed in to change notification settings - Fork 11
feat: adding rows count to textarea #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #785 +/- ##
=======================================
Coverage 85.40% 85.40%
=======================================
Files 791 791
Lines 16155 16156 +1
Branches 2060 2060
=======================================
+ Hits 13797 13798 +1
Misses 2327 2327
Partials 31 31
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
So my main goal here is that we can style our component in the same way we'd style the text area if we were using it directly. Inheriting individual properties is a bit brittle, but if we can't come up with a better way I think it's better than the input. |
This comment has been minimized.
This comment has been minimized.
Unit Test Results 4 files 249 suites 14m 9s ⏱️ Results for commit 6deb3bf. |
Description
Testing
Visual Testing
Old:
New:
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.