fix: waterfall undefined strings #803
Conversation
Codecov Report
@@ Coverage Diff @@
## main #803 +/- ##
=======================================
Coverage 85.41% 85.42%
=======================================
Files 792 792
Lines 16178 16180 +2
Branches 2063 2067 +4
=======================================
+ Hits 13819 13821 +2
Misses 2328 2328
Partials 31 31
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
| @@ -115,7 +115,6 @@ export class SequenceChartComponent implements OnChanges { | |||
| id: segment.id, | |||
| start: segment.start - minStart, | |||
| end: segment.end - minStart, | |||
| label: segment.label, | |||
There was a problem hiding this comment.
I couldn't see anywhere this was used, so removed it. cc: @anandtiwary to confirm this is okay.
| } | ||
|
|
||
| private buildTitleString(trace: Trace): string { | ||
| if (trace.spans?.length === 1) { | ||
| const entrySpan = trace.spans[0]; | ||
|
|
||
| return `${entrySpan.serviceName as string} ${entrySpan.displaySpanName as string}`; | ||
| return `${entrySpan.serviceName as string} ${(entrySpan.displaySpanName as string) ?? ''}`.trim(); |
There was a problem hiding this comment.
Wouldn't it be correct to do the trim() before generating the string?
There was a problem hiding this comment.
In this case since we also have a space in the middle of the template, I trim() once the complete string is built to remove any space between (since there might not be a displaySpanName).
Description
This fixes undefined strings in several places for waterfall.