feat: update combo-box to account for 'create new' autocomplete use cases #854
Conversation
Codecov Report
@@ Coverage Diff @@
## main #854 +/- ##
==========================================
- Coverage 85.47% 85.47% -0.01%
==========================================
Files 796 797 +1
Lines 16310 16351 +41
Branches 1940 1955 +15
==========================================
+ Hits 13941 13976 +35
- Misses 2337 2343 +6
Partials 32 32
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| private setFilteredOptions(text?: string): void { | ||
| this.filteredOptions = (this.options ?? []).filter(option => text === undefined || option.text.includes(text)); | ||
| this.filteredOptions = (this.options ?? []).filter( | ||
| option => text === undefined || option.text.toLowerCase().includes(text.toLowerCase()) |
There was a problem hiding this comment.
if text is undefined then we don't need to call filter.
| private setFilteredOptions(text?: string): void { | ||
| this.filteredOptions = (this.options ?? []).filter(option => text === undefined || option.text.includes(text)); | ||
| this.filteredOptions = (this.options ?? []).filter( |
There was a problem hiding this comment.
Can we call it searchText?
| } | ||
|
|
||
| this.scrollIntoViewService.scrollIntoView(this.optionElements.get(this.highlightedOptionIndex)?.nativeElement); |
There was a problem hiding this comment.
Nice. Is it this easy to scroll and show a particular element in the view? I can use it at so many other places now.
There was a problem hiding this comment.
Yep! Just this easy.
This comment has been minimized.
This comment has been minimized.
Unit Test Results 4 files 252 suites 14m 54s ⏱️ Results for commit 6fc0297. |
Description
This adds the ability to "Create new" value using combo-box autocomplete.