Skip to content

refactor: push variables down to app-aware-dash #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

aaron-steinfeld
Copy link
Contributor

Description

Pushing the ability to set variables down to app aware dashboard, since it has nothing to do with navigation.

Testing

Quick sanity test, but ust a refactor of an existing feature.

@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner June 16, 2021 12:13
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #934 (3f60d05) into main (6a049e3) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #934      +/-   ##
==========================================
- Coverage   85.14%   85.14%   -0.01%     
==========================================
  Files         806      806              
  Lines       16638    16643       +5     
  Branches     2094     2097       +3     
==========================================
+ Hits        14166    14170       +4     
- Misses       2440     2441       +1     
  Partials       32       32              
Impacted Files Coverage Δ
...dashboard-wrapper/navigable-dashboard.component.ts 97.77% <ø> (+1.85%) ⬆️
...d-wrapper/application-aware-dashboard.component.ts 83.78% <83.33%> (-1.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a049e3...3f60d05. Read the comment docs.

@github-actions

This comment has been minimized.

@aaron-steinfeld aaron-steinfeld merged commit fa25c51 into main Jun 16, 2021
@aaron-steinfeld aaron-steinfeld deleted the push-down-variables branch June 16, 2021 12:35
@github-actions
Copy link

Unit Test Results

    4 files  ±0  258 suites  ±0   17m 2s ⏱️ + 1m 55s
929 tests ±0  929 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
935 runs  ±0  935 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit fa25c51. ± Comparison against base commit 6a049e3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants