fix: add missing netty constraint on client utils #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-steinfeld
requested review from
tim-mwangi,
surajpuvvada and
avinashkolluru
as code owners
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #30 +/- ##
=========================================
Coverage 70.22% 70.22%
Complexity 105 105
=========================================
Files 18 18
Lines 309 309
Branches 22 22
=========================================
Hits 217 217
Misses 74 74
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
avinashkolluru
approved these changes
Jun 10, 2022
tim-mwangi
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we had only declared a netty constraint on our server util package, but both our grpc clients and servers use netty as transport. Adding the constraint to client lib here.