Skip to content

Conversation

aaron-steinfeld
Copy link
Contributor

Description

  • Updated toString methods to print claims rather than the actual auth header
  • Added a generic method to get any claim off auth header, deprecated getRoles in favor of that

Testing

Updated unit tests

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #36 (24c9611) into main (577ab05) will increase coverage by 0.41%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##               main      #36      +/-   ##
============================================
+ Coverage     72.02%   72.43%   +0.41%     
- Complexity      127      129       +2     
============================================
  Files            19       19              
  Lines           361      370       +9     
  Branches         22       21       -1     
============================================
+ Hits            260      268       +8     
- Misses           79       81       +2     
+ Partials         22       21       -1     
Flag Coverage Δ
unit 72.43% <66.66%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ertrace/core/grpcutils/context/RequestContext.java 63.79% <57.14%> (-1.60%) ⬇️
...g/hypertrace/core/grpcutils/context/JwtParser.java 77.77% <70.58%> (+8.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-steinfeld aaron-steinfeld merged commit 1f5edb2 into main Sep 28, 2022
@aaron-steinfeld aaron-steinfeld deleted the claims branch September 28, 2022 01:39
@github-actions
Copy link

Unit Test Results

12 files  ±0  12 suites  ±0   19s ⏱️ +4s
61 tests  - 1  61 ✔️  - 1  0 💤 ±0  0 ❌ ±0 

Results for commit 1f5edb2. ± Comparison against base commit 577ab05.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants