added dependency constraint #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #37 +/- ##
=========================================
Coverage 72.43% 72.43%
Complexity 129 129
=========================================
Files 19 19
Lines 370 370
Branches 21 21
=========================================
Hits 268 268
Misses 81 81
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
skjindal93
previously approved these changes
Oct 6, 2022
skjindal93
reviewed
Oct 6, 2022
grpc-context-utils/build.gradle.kts
Outdated
Comment on lines
15
to
17
| constraints { | ||
| implementation("com.fasterxml.jackson.core:jackson-databind:2.13.4") | ||
| } |
There was a problem hiding this comment.
Can you add the constraints section below the implementations? Please also add the reason for the constraint. You can add a link for the CVE like
constraints {
implementation("com.fasterxml.jackson.core:jackson-databind:2.13.4") {
because("https://nvd.nist.gov/vuln/detail/CVE-2022-42004")
}
}
avinashkolluru
approved these changes
Oct 6, 2022
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.