Skip to content

Conversation

aaron-steinfeld
Copy link
Contributor

Description

Previously had to either add it on each registry channel call, or subclass the registry.

Testing

Added UT

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #42 (89e9b44) into main (04adafb) will decrease coverage by 0.20%.
The diff coverage is 76.47%.

@@             Coverage Diff              @@
##               main      #42      +/-   ##
============================================
- Coverage     73.80%   73.59%   -0.21%     
- Complexity      139      145       +6     
============================================
  Files            19       20       +1     
  Lines           397      409      +12     
  Branches         22       22              
============================================
+ Hits            293      301       +8     
- Misses           82       85       +3     
- Partials         22       23       +1     
Flag Coverage Δ
unit 73.59% <76.47%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...race/core/grpcutils/client/GrpcRegistryConfig.java 33.33% <33.33%> (ø)
...grpcutils/client/InProcessGrpcChannelRegistry.java 80.64% <60.00%> (-4.55%) ⬇️
...ace/core/grpcutils/client/GrpcChannelRegistry.java 85.50% <100.00%> (+1.13%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@laxmanchekka laxmanchekka merged commit 27870c2 into main Dec 7, 2022
@laxmanchekka laxmanchekka deleted the all-client-interceptor-support branch December 7, 2022 03:24
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

Unit Test Results

12 files  ±0  12 suites  ±0   16s ⏱️ -3s
70 tests +2  70 ✔️ +2  0 💤 ±0  0 ❌ ±0 

Results for commit 27870c2. ± Comparison against base commit 04adafb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants