refactor: add support for better exception propagation and creation #56
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
============================================
+ Coverage 75.50% 79.28% +3.78%
- Complexity 162 172 +10
============================================
Files 23 23
Lines 449 478 +29
Branches 24 25 +1
============================================
+ Hits 339 379 +40
+ Misses 88 75 -13
- Partials 22 24 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| } | ||
| // Otherwise, we've found a status so collect any trailers from it and merge them on top of | ||
| // any trailers we can find from descendents | ||
| Metadata trailersFromCauseDescendents = this.collectAllTrailersFromCause(statusFromCause); |
There was a problem hiding this comment.
Could this collection grow out of bounds affecting memory?
There was a problem hiding this comment.
Not really a concern. It only recurses for the length of the causal chain, so it's bounded by the size of that. As soon as we run out of causes or hit an unknown cause, we exit recursion (the two base cases above). The causal chain must necessarily be the same depth as this recursion (or longer), and each link in that is a throwable that contains a superset of the data we're copying out.
Description
Made context propagation automatic, removed requirement to provide context when creating context.