chore: add external error interceptor #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
============================================
- Coverage 77.66% 72.32% -5.34%
Complexity 172 172
============================================
Files 24 25 +1
Lines 488 524 +36
Branches 26 26
============================================
Hits 379 379
- Misses 85 121 +36
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sarthak77
previously approved these changes
May 31, 2024
sarthak77
reviewed
May 31, 2024
| * This interceptor can be used at the edge to scrub any sensitive information such as an exception | ||
| * cause or metadata off the context before propagating it | ||
| */ | ||
| public class ExternalExceptionInterceptor implements ServerInterceptor { |
There was a problem hiding this comment.
Should we define this as an abstract class so that one can define custom message and custom trailer building logic 🤔
There was a problem hiding this comment.
Not an abstract class and we typically would not expect these t o be configured differently in different services but I'll open up a couple of protected hooks for extension if needed.
tim-mwangi
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This interceptor is meant to be used in edge services to prevent leaking any sensitive information. It only propagates status code, an external message and request ID, if set. All other metadata such as cause and metadata are stripped.