Skip to content

Minor style fixes #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2025
Merged

Minor style fixes #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 9 additions & 23 deletions .../org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,7 @@
CacheBuilder.newBuilder()
.expireAfterAccess(60, TimeUnit.MINUTES) // Auto-evict after 60 minutes
.maximumSize(10000) // Limit max cache size
.build(
new CacheLoader<>() {
@Override
public Optional<CircuitBreaker> load(String key) {
return buildNewCircuitBreaker(key);
}
});
.build(CacheLoader.from(this::buildNewCircuitBreaker));

Check warning on line 30 in grpc-circuitbreaker-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerProvider.java

View check run for this annotation

Codecov / codecov/patch

grpc-circuitbreaker-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerProvider.java#L30 

Added line #L30 was not covered by tests

public ResilienceCircuitBreakerProvider(
CircuitBreakerRegistry circuitBreakerRegistry,
Expand Down Expand Up @@ -81,24 +75,16 @@

private Optional<CircuitBreaker> buildNewCircuitBreaker(String circuitBreakerKey) {
return Optional.ofNullable(circuitBreakerConfigMap.get(circuitBreakerKey))
.map(config -> circuitBreakerRegistry.circuitBreaker(circuitBreakerKey, config))
.or(

Check warning on line 79 in grpc-circuitbreaker-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerProvider.java

View check run for this annotation

Codecov / codecov/patch

grpc-circuitbreaker-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerProvider.java#L78-L79 

Added lines #L78 - L79 were not covered by tests
() ->
defaultEnabled
? Optional.of(circuitBreakerRegistry.circuitBreaker(circuitBreakerKey))
: Optional.empty())

Check warning on line 83 in grpc-circuitbreaker-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerProvider.java

View check run for this annotation

Codecov / codecov/patch

grpc-circuitbreaker-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerProvider.java#L82-L83 

Added lines #L82 - L83 were not covered by tests
.map(
config -> {
CircuitBreaker circuitBreaker =
circuitBreakerRegistry.circuitBreaker(circuitBreakerKey, config);
attachListeners(circuitBreaker); // Attach listeners here
circuitBreaker -> {
attachListeners(circuitBreaker);

Check warning on line 86 in grpc-circuitbreaker-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerProvider.java

View check run for this annotation

Codecov / codecov/patch

grpc-circuitbreaker-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerProvider.java#L86 

Added line #L86 was not covered by tests
return circuitBreaker;
})
.or(
() -> {
if (defaultEnabled) {
CircuitBreaker circuitBreaker =
circuitBreakerRegistry.circuitBreaker(circuitBreakerKey);
attachListeners(
circuitBreaker); // Attach listeners here for default circuit breaker
return Optional.of(circuitBreaker);
} else {
return Optional.empty();
}
});
}
}
Loading