Dynamically disable wrapping of servlet types if cast exception happens #138
Conversation
|
|
||
| if (throwable instanceof ClassCastException) { | ||
| ClassCastException cast = (ClassCastException) throwable; | ||
| System.out.println(cast.getMessage().contains("hypertrace")); |
There was a problem hiding this comment.
Worth to mention why this piece is important? Maybe abstracting "hypertrace" into something meaningful like HYPERTRACE_OWN_PREFIX or something that makes sense?
There was a problem hiding this comment.
ignore this code completely this is just a nasty example.
The right solution could parse the class name and store it into the global config. The global config would be used by instrumentation points that create wrappers. If no exception is recorded for the wrapped type the wrapping would be applied.
There was a problem hiding this comment.
Another interesting fact in this example is the place where the exceptions are caught. In servlet this can be done in exit filter advice. In other frameworks it can be a different place.
The problem also is if the casting would be inside user defined try-catch(Throwable) block, this instrumentation would not catch this. I have tried to define adice for ClassCastException but that does not seem to be triggered.
pavolloffay
force-pushed
the
intercept-class-cast
branch
2 times, most recently
from
7d6e5f1 to
34e77ec
Compare
pavolloffay
changed the title
| } | ||
|
|
||
| @Test | ||
| public void requestCast() throws Exception { |
There was a problem hiding this comment.
@davexroth @surajpuvvada here is an example of the cast exception. The first request fails, however the second passes but the attributes that are captured via wrappers are omitted. This is the best what we can do.
…appens Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
pavolloffay
force-pushed
the
intercept-class-cast
branch
from
34e77ec to
8fc693f
Compare
Signed-off-by: Pavol Loffay p.loffay@gmail.com