-
Notifications
You must be signed in to change notification settings - Fork 13
Add ReceiveSendGreetingServlet and publish workflow for matrix project #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ReceiveSendGreetingServlet and publish workflow for matrix project #272
Conversation
Some files have OTEL license header and some not, could we add the license header to the missing files? We should preserve OTEL license header. |
@pavolloffay Below files do not have OTEL header (with reason for missing):
|
please add it to our copy. Also in the matrix readme mention that this is from OTEL |
done 👍 |
import java.net.URLConnection; | ||
import java.util.stream.Collectors; | ||
|
||
public class ReceiveSendGreetingServlet extends HttpServlet { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we rename it EchoServlet
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could do servlet just simply read the body to a buffer and write it back with the same content type?
This way we don't need dep on Gson and additional classes. To test response heders capture the servlet could also send some test response header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pavolloffay made below changes.
- renamed the servlet to EchoServlet
- copying request as response . Header going as test headers.
Description
Add ReceiveSendGreetingServlet.java and publish workflow for matrix project
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.