Skip to content

Bump OTEL dependency to 0.17.0 #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 3, 2021
Merged

Conversation

pavolloffay
Copy link
Member

No description provided.

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@@ -83,6 +83,6 @@ tasks {
relocate("io.opentelemetry.spi", "io.opentelemetry.javaagent.shaded.io.opentelemetry.spi")
relocate("io.opentelemetry.context", "io.opentelemetry.javaagent.shaded.io.opentelemetry.context")
relocate("io.opentelemetry.extension.kotlin", "io.opentelemetry.javaagent.shaded.io.opentelemetry.extension.kotlin")
relocate ("io.opentelemetry.extension.trace.propagation", "io.opentelemetry.javaagent.shaded.io.opentelemetry.extension.trace.propagation")
relocate("io.opentelemetry.extension.aws", "io.opentelemetry.javaagent.shaded.io.opentelemetry.extension.aws")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc) @shashank11p we will need to add this to the blocking JAR as well

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@pavolloffay
Copy link
Member Author

Condition not satisfied:

traces.countSpansByName(getSpanName('/this-is-definitely-not-there-but-there-should-be-a-trace-nevertheless')) == 1
|      |                |                                                                                      |
|      0                HandlerWrapper.handle                                                                  false
<org.hypertrace.agent.smoketest.TraceInspector@b016b4e traces=[resource_spans {
  resource {
    attributes {
      key: "service.name"
      value {
        string_value: "ciservice"
      }
    }
    attributes {
      key: "container.id"
      value {
        string_value: "48b9f248787de10f30e0aa71c8966e24275fd4e8e2056ab4b2dccef856c47f5e"
      }
    }
  }
  instrumentation_library_spans {
    instrumentation_library {
    }
    spans {
      trace_id: ">(}\247H\246\203\033\332XO[0(3k"
      span_id: "ke\363&\330\322#S"
      parent_span_id: "\376<w\340~\233\326;"
      name: "response.senderror"
      start_time_unix_nano: 1614785016863431000
      end_time_unix_nano: 1614785016863488000
      attributes {
        key: "thread.name"
        value {
          string_value: "qtp1629032994-13"
        }
      }
      attributes {
        key: "otel.library.name"
        value {
          string_value: "io.opentelemetry.javaagent.servlet-common"
        }
      }
      attributes {
        key: "otel.library.version"
        value {
          string_value: "0.10.4-SNAPSHOT"
        }
      }
      attributes {
        key: "thread.id"
        value {
          string_value: "13"
        }
      }
      attributes {
        key: "net.host.ip"
        value {
          string_value: "192.168.48.4"
        }
      }
      status {
      }
    }
  }
}
resource_spans {
  resource {
    attributes {
      key: "service.name"
      value {
        string_value: "ciservice"
      }
    }
    attributes {
      key: "container.id"
      value {
        string_value: "48b9f248787de10f30e0aa71c8966e24275fd4e8e2056ab4b2dccef856c47f5e"
      }
    }
  }
  instrumentation_library_spans {
    instrumentation_library {
    }
    spans {
      trace_id: ">(}\247H\246\203\033\332XO[0(3k"
      span_id: "\376<w\340~\233\326;"
      name: "handlerwrapper.handle"
      kind: SPAN_KIND_SERVER
      start_time_unix_nano: 1614785016863010000
      end_time_unix_nano: 1614785016863594000
      attributes {
        key: "otel.status_code"
        value {
          string_value: "ERROR"
        }
      }
      attributes {
        key: "http.url"
        value {
          string_value: "http://localhost:56262/this-is-definitely-not-there-but-there-should-be-a-trace-nevertheless"
        }
      }
      attributes {
        key: "net.peer.port"
        value {
          string_value: "58508"
        }
      }
      attributes {
        key: "http.user_agent"
        value {
          string_value: "okhttp/4.9.0"
        }
      }
      attributes {
        key: "thread.id"
        value {
          string_value: "13"
        }
      }
      attributes {
        key: "error"
        value {
          string_value: ""
        }
      }
      attributes {
        key: "otel.library.version"
        value {
          string_value: "0.10.4-SNAPSHOT"
        }
      }
      attributes {
        key: "http.client_ip"
        value {
          string_value: "192.168.48.1"
        }
      }
      attributes {
        key: "http.method"
        value {
          string_value: "GET"
        }
      }
      attributes {
        key: "thread.name"
        value {
          string_value: "qtp1629032994-13"
        }
      }
      attributes {
        key: "otel.library.name"
        value {
          string_value: "io.opentelemetry.javaagent.jetty"
        }
      }
      attributes {
        key: "http.flavor"
        value {
          string_value: "HTTP/1.1"
        }
      }
      attributes {
        key: "http.status_code"
        value {
          string_value: "404"
        }
      }
      attributes {
        key: "net.peer.ip"
        value {
          string_value: "192.168.48.1"
        }
      }
      attributes {
        key: "net.host.ip"
        value {
          string_value: "192.168.48.4"
        }
      }
      status {
      }
    }
  }
}
]>

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@pavolloffay pavolloffay requested a review from shashank11p March 3, 2021 17:44
@pavolloffay pavolloffay merged commit 8e5e87a into hypertrace:main Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant