Add resource attributes #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add abstract client tests (hypertrace#246)
Pull hypertrace main
publishing filter-api (hypertrace#252)
pull main
pull main
pavolloffay
reviewed
Apr 6, 2021
...xtensions/src/main/java/org/hypertrace/agent/otel/extensions/HypertraceResourceProvider.java
Show resolved
Hide resolved
...xtensions/src/main/java/org/hypertrace/agent/otel/extensions/HypertraceResourceProvider.java
Outdated
Show resolved
Hide resolved
| } catch (ClassNotFoundException e) { | ||
| log.warn("Could not load HypertraceAgent class"); | ||
| } | ||
| builder.put(ResourceAttributes.TELEMETRY_SDK_VERSION, agentVersion); |
There was a problem hiding this comment.
is this correct? The SDK version does not match the agent version
| log.warn("Could not load HypertraceAgent class"); | ||
| } | ||
| builder.put(ResourceAttributes.TELEMETRY_SDK_VERSION, agentVersion); | ||
| builder.put(ResourceAttributes.TELEMETRY_AUTO_VERSION, agentVersion); |
There was a problem hiding this comment.
can you point me to the spec that defines what version should be used here?
pavolloffay
reviewed
Apr 6, 2021
| builder.put(ResourceAttributes.TELEMETRY_SDK_VERSION, agentVersion); | ||
| builder.put(ResourceAttributes.TELEMETRY_AUTO_VERSION, agentVersion); | ||
| builder.put(AttributeKey.stringKey(HYPERTRACE_MODULE_NAME), "java"); | ||
| builder.put(AttributeKey.stringKey(HYPERTRACE_MODULE_VERSION), agentVersion); |
There was a problem hiding this comment.
@davexroth related to the wiki doc - it seems there is quite large redundancy in the version attributes.
Could we use only a single one if the values are repeated?
There was a problem hiding this comment.
I replied to your comment on the wiki.
pavolloffay
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update telemetry resource attributes and add hypertrace attributes.