Skip to content

Remove bugy, disabled instrumentation #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2021

Conversation

pavolloffay
Copy link
Member

Removes "all" alternative instrumentation from apache async client. It's disabled by default and does not pass all client tests.

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@pavolloffay
Copy link
Member Author

@ryandens

  "command": "bad-command",
  "org": "hypertrace",
  "metadata": {
    "error-message": "`snyk` requires an authenticated account. Please run `snyk auth` and try again.",
    "error": "MissingApiTokenError: `snyk` requires an authenticated account. Please run `snyk auth` and try again.\n    at Object.apiTokenExists (/snapshot/snyk/dist/lib/api-token.js:23:15)\n    at Object.validateCredentials (/snapshot/snyk/dist/cli/commands/test/validate-credentials.js:7:21)\n    at test (/snapshot/snyk/dist/cli/commands/test/index.js:33:28)\n    at Object.method (/snapshot/snyk/dist/lib/hotload.js:14:20)\n    at runCommand (/snapshot/snyk/dist/cli/index.js:44:38)\n    at main (/snapshot/snyk/dist/cli/index.js:253:21)\n    at Object.<anonymous> (/snapshot/snyk/dist/cli/index.js:270:13)\n    at Module._compile (pkg/prelude/bootstrap.js:1503:22)\n    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)\n    at Module.load (internal/modules/cjs/loader.js:863:32)\n    at Function.Module._load (internal/modules/cjs/loader.js:708:14)\n    at Function.runMain (pkg/prelude/bootstrap.js:1558:12)\n    at internal/main/run_main_module.js:17:47",
    "error-code": 401,
    "command": "test"
  },

it seems snyk is failing on auth.

@pavolloffay pavolloffay merged commit d7cf66c into hypertrace:main May 10, 2021
@ryandens
Copy link
Member

Thanks, @pavolloffay! I'm taking a look now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants