Align SB smoke test image with servlet containers

[pavolloffay]

No description provided.

[pavolloffay]

The undertow tests seems to be flaky

UndertowInstrumentationTest > postUrlEncoded() FAILED
    org.opentest4j.AssertionFailedError at UndertowInstrumentationTest.java:113

cc) @ryandens

[ryandens]

The undertow tests seems to be flaky

UndertowInstrumentationTest > postUrlEncoded() FAILED
    org.opentest4j.AssertionFailedError at UndertowInstrumentationTest.java:113

cc) @ryandens

Thanks! I noticed this as well, still trying to zero in on the source of the flakiness, but working on this in the background. I have a suspicion that it's a thread-safety issue with how that test utilizes the in-memory exporter, so at least it doesn't seem to be an inconsistency issue with the production agent code 🤞

[pavolloffay]

on JDK8 it fails randomly.

while ./gradlew clean :instrumentation:undertow:undertow-1.4:test; do :; done

[pavolloffay]

I have a suspicion that it's a thread-safety issue with how that test utilizes the in-memory exporter, so at least it doesn't seem to be an inconsistency issue with the production agent code crossed_fingers

I would not be so sure bc spans are reported but the body attribute is missing.

[ryandens]

I have a suspicion that it's a thread-safety issue with how that test utilizes the in-memory exporter, so at least it doesn't seem to be an inconsistency issue with the production agent code crossed_fingers

I would not be so sure bc spans are reported but the body attribute is missing.

Huh, interesting. Where are you seeing that? The test failure you posted (and that I've seen as well) shows the assertion in line 113 failing which is just asserting the size of the traces list? Do the logs show the trace reported without the body attribute? Or did you get a test failure with a different assertion error?

[pavolloffay]

I get failures in my editor on line 117 ass well :/

    assertEquals(
        "{\"echo\": \"bar\"}",
        spanData.getAttributes().get(HypertraceSemanticAttributes.HTTP_RESPONSE_BODY));

[ryandens]

Thanks! I hadn't gotten that one yet, but this will definitely help

[pavolloffay]

The failing line 117 is my bad, wrongly initialized classpath in IDE, here is the fix for the flaky test #331