Skip to content

🐛 Fix spring boot smoke test taking a long time, set more sensible default for OPA endpoint #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2021

Conversation

ryandens
Copy link
Member

Description

The spring boot smoke test was sometimes timing out and the pipeline would run for a long time. We want to fail fast and loudly.

In addition, sets the OPA reporting addres to be http://localhost:8181 rather than opa.traceable.ai

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@ryandens ryandens merged commit 306eaa4 into main Jul 23, 2021
@ryandens ryandens deleted the fix-spring-boot-smoke-test branch July 23, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants