Skip to content

Conversation

ryandens
Copy link
Member

Description

Handle charset with quality factor. We came across this log message in a service that uses this java agent:

[opentelemetry.auto.trace 2021-06-29 16:43:30:382 +0000] [reactor-http-epoll-3] ERROR org.hypertrace.agent.core.instrumentation.utils.ContentTypeCharsetUtils - Could not parse encoding utf-8;q=.2 to charset, using default ISO-8859-1

Testing

Added a unit test with a valid Content-Type header containing a charset with a quality factor.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@ryandens ryandens requested a review from shashank11p August 19, 2021 14:20
@ryandens ryandens merged commit 994bef6 into main Aug 19, 2021
@ryandens ryandens deleted the charset-quality-factor branch August 19, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants