Upgrade otel 1 5 3 #346
Merged
Upgrade otel 1 5 3 #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryandens
force-pushed
the
upgrade-otel-1-5-2
branch
from
e1c6816 to
1ac3725
Compare
ryandens
force-pushed
the
upgrade-otel-1-5-2
branch
2 times, most recently
from
038e96b to
08e8f0c
Compare
ryandens
force-pushed
the
upgrade-otel-1-5-2
branch
from
08e8f0c to
8f0ac24
Compare
pavolloffay
approved these changes
Sep 3, 2021
| @@ -28,6 +28,8 @@ dependencies { | |||
| implementation(gradleApi()) | |||
| implementation(localGroovy()) | |||
|
|
|||
| implementation("io.opentelemetry.instrumentation.muzzle-generation:io.opentelemetry.instrumentation.muzzle-generation.gradle.plugin:0.7.0") | |||
There was a problem hiding this comment.
If I am not mistaked these plugins should substitute MuzzlePlugin.groovy so could we remove MuzzlePlugin.groovy?
There was a problem hiding this comment.
I, unfortunately, wasn't able to drop in the plugin class as a replacement yet, but looking forward to doing that as we incrementally migrate these modules to more standard patterns!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades OTEL to 1.5.3. Mostly just renames and accounting for changed signatures of opentelemetry APIs without any significant behavior changes
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.