✨ Add support for custom certificate files #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ert_file configured'
tim-mwangi
reviewed
Oct 8, 2021
| if (agentConfig.getReporting().getTraceReporterType() == TraceReporterType.OTLP) { | ||
| configProperties.put(OTEL_OTLP_CERT, agentConfig.getReporting().getCertFile().getValue()); | ||
| } else { | ||
| log.warn( |
There was a problem hiding this comment.
not easy to support for zipkin as well?
There was a problem hiding this comment.
Sadly not, their implementation is of this is solely implemented on their OTLP-based exporters. If we need a workaround, there are java command-line options we could put together for a user to configure their JVM to trust a specific certificate.
tim-mwangi
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the cert_file configuration, configuring the underlying OTLP exporter with the cert file path.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.