ENG-16503 Show request body for x-www-form-urlencoded HTTP requests #363
Conversation
|
Implemented the ability to capture request bodies for HTTP requests in the x-www-form-urlencoded format. |
| sb.append(","); | ||
| } | ||
|
|
||
| sb.append(String.format("\n \"%s\": \"%s\"", key, value)); |
There was a problem hiding this comment.
Can't there be a nested json?
There was a problem hiding this comment.
Not in this case; the data for x-www-form-urlencoded request bodies comes in as string-valued properties. However, I had put this code in here because I was having problems with snyk-scan complaining about a specific version of Jackson; originally, I used Jackson to create the JSON here, and I thought the problem might have something to do with my change, so I changed the implementation to construct the JSON manually. However, it turns out that the snyk-scan wasn't caused by my change; instead I fixed the problem by upgrading the Jackson version. I will go back and replace this code with a Jackson implementation.
| return new ObjectMapper().writeValueAsString(obj); | ||
| } catch (JsonProcessingException e) { | ||
| throw new RuntimeException(e); | ||
| public static String convertToJSONString(Map<?, ?> map) { |
There was a problem hiding this comment.
How does this change show request body for x-www-form-urlencoded HTTP requests?
There was a problem hiding this comment.
It's a utility method for converting string Maps to JSON. In order for Span attributes to show correctly in the UI, they must be in JSON format. However, as indicated in my other comment, I'll be changing the implementation to use Jackson to perform this conversion. I'll also add some Javadoc for this method.
| import org.hypertrace.agent.core.instrumentation.buffer.BoundedCharArrayWriter; | ||
| import org.hypertrace.agent.core.instrumentation.buffer.ByteBufferSpanPair; | ||
| import org.hypertrace.agent.core.instrumentation.buffer.CharBufferSpanPair; | ||
| import org.hypertrace.agent.core.instrumentation.buffer.*; |
There was a problem hiding this comment.
Was this intentional or intellij? I think we should not use *
| import org.hypertrace.agent.core.instrumentation.buffer.BoundedCharArrayWriter; | ||
| import org.hypertrace.agent.core.instrumentation.buffer.ByteBufferSpanPair; | ||
| import org.hypertrace.agent.core.instrumentation.buffer.CharBufferSpanPair; | ||
| import org.hypertrace.agent.core.instrumentation.buffer.*; |
There was a problem hiding this comment.
same imports here and in other files as well
There was a problem hiding this comment.
That was Intellij
Description
Please include a summary of the change, motivation and context.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.