Catch our blocking exception when it is nested. Eg. spring framework. #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashank11p
approved these changes
Oct 20, 2022
I only see one spot where we "catch" this exception. The other areas just check and rethrow the exception. In those try blocks, they all call |
shashank11p
approved these changes
Oct 21, 2022
|
I'm going to merge this and open a new jira to track the snyk error work. I think it's a bigger/wider ranging effort. |
shashank11p
pushed a commit
that referenced
this pull request
Feb 24, 2023
…#373) * Catch our blocking exception when it is nested. Eg. spring framework. * Add test * Running spotlessapply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, motivation and context.
When a filter blocks a request (eg. traceable filter), the http code returned is 500. It should be 403. The happens when the exception that we throw is nested and we are not catching it properly. This can be produced when used the spring framework as an app.
Testing
Manual tested with a spring framework app
Checklist: