Request body blocking for netty #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanericson
reviewed
Feb 24, 2023
| @@ -55,6 +57,14 @@ public void channelRead(ChannelHandlerContext ctx, Object msg) { | |||
| return; | |||
| } | |||
| } | |||
| if (msg instanceof HttpContent) { | |||
| if (FilterRegistry.getFilter().evaluateRequestBody(span, null, null)) { | |||
There was a problem hiding this comment.
What does this mean? It's passing null for request body?
There was a problem hiding this comment.
We do not have the request body at this point, but we have the request body in span attributes. And the filter impl will use request body from span attributes
ryanericson
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds request body blocking capability on netty