upgrade otel version to 1.24 #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-mwangi
reviewed
Apr 12, 2023
instrumentation/build.gradle.kts
Outdated
| exclude("io/opentelemetry/context/**") | ||
| exclude(dependency("io.opentelemetry:opentelemetry-api")) | ||
| exclude("io/opentelemetry/instrumentation/api/**") | ||
| // // exclude bootstrap part of javaagent-extension-api |
tim-mwangi
reviewed
Apr 12, 2023
tim-mwangi
reviewed
Apr 12, 2023
...javaagent/instrumentation/hypertrace/jaxrs/v2_0/JaxrsAsyncClientBodyInstrumentationTest.java
Outdated
Show resolved
Hide resolved
tim-mwangi
reviewed
Apr 12, 2023
...etry/javaagent/instrumentation/hypertrace/jaxrs/v2_0/JaxrsClientBodyInstrumentationTest.java
Outdated
Show resolved
Hide resolved
|
Aside from the commented code Tim pointed out, lgtm. |
|
Removed jaxrs instrumentation since it did not provide any additional value to us. The client spans are already being created by apache-httpclient instrumentation. And the passing tests show that we will be able to capture all that we need without this extra instrumentation as well |
tim-mwangi
approved these changes
Apr 13, 2023
* fix tomee test * fix Play test * fix liberty test * add sock host port as well * fix grpc test * fix spring boot tests * format * fix wildify test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, motivation and context.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.