Custom block code and msg #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varkey98
reviewed
Jan 2, 2024
filter-api/src/main/java/org/hypertrace/agent/filter/MultiFilter.java
Outdated
Show resolved
Hide resolved
varkey98
approved these changes
Jan 2, 2024
ryanericson
reviewed
Jan 3, 2024
Yes, for now it's setting the Status description as the msg provided. I'll just revert that in grpc, and we will update grpc when we finalise how to set it for grpc. |
Reverted these. Right now, we do not add custom status and msgs for grpc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a FilterResult in the Filter API, so that filters can provide custom blocking status code and message along with the FilterResult.
Using this FilterResult to block and set the response status and message accordingly