Eng 9536 add filters #223
Closed
Eng 9536 add filters #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcbjBlueMars
reviewed
Jul 6, 2021
rcbjBlueMars
reviewed
Jul 6, 2021
rcbjBlueMars
reviewed
Jul 6, 2021
rcbjBlueMars
suggested changes
Jul 6, 2021
rcbjBlueMars
reviewed
Jul 6, 2021
tox.ini
Outdated
| commands=pytest -rPx src/hypertrace | ||
| commands= | ||
| pytest -rPx src/hypertrace | ||
| pytest -rPx tests/agent |
There was a problem hiding this comment.
New integration tests should be added in the Makefile's integration-tests rule, not here.
There was a problem hiding this comment.
Okay, just to verify, unit tests are expected to be in the src directory alongside library files?
Integrations tests belong under tests/<framework>?
There was a problem hiding this comment.
That is the pattern @jcchavezs established.
There was a problem hiding this comment.
Awesome, thanks for the clarification here :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds filter support for flask & grpc instrumentation.
Testing
Tests added here mimic the behavior of existing grpc & flask tests. & assert the permission denied & 403 errors.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.