Skip to content

Conversation

pratikpawar05
Copy link

  • Enabled configuration of the Faker locale.
  • Implemented tests to verify proper Faker locale usage.
  • Refactored the factory method to leverage the ModelFactory helper.

- Implemented tests to verify proper Faker locale usage.
- Refactored the factory method to leverage the `ModelFactory` helper.
@pratikpawar05
Copy link
Author

Description

This PR introduces the ability to configure the Faker locale, adds corresponding test coverage to ensure it's correctly applied, and refactors the factory method to utilize the ModelFactory helper.

Why?

This change supports the ability to set a custom Faker locale as documented in the Hypervel documentation.

💡 Tip: You can set the Faker locale by adding a faker_locale option to your config/app.php configuration file:

'faker_locale' => 'fr_FR',

This PR ensures the factory respects that configuration setting and generates localized fake data accordingly.

@albertcht albertcht changed the title Support configurable Faker locale with test coverage and factory method refactor improve: support model factory with configurable locale parameter May 24, 2025
@albertcht
Copy link
Member

Hi @pratikpawar05 , thanks for your pull request.

@albertcht albertcht merged commit ebfaf14 into hypervel:main May 24, 2025
6 checks passed
@albertcht albertcht added the enhancement Improved feature or adjustments. label May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improved feature or adjustments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants