V3 missing client user id filter #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rrathinasabapath
requested review from
arao6,
jbausch-hw,
jportner-hw and
ramahalingam
ramahalingam
reviewed
Apr 9, 2021
| @@ -0,0 +1,3 @@ | |||
| curl -X "GET" "https://api.sandbox.hyperwallet.com/rest/v3/users" \ | |||
There was a problem hiding this comment.
Pls add some query parameters for filtering options here.
There was a problem hiding this comment.
As discussed before this couldnt be done as testing dynamically with query parameters is not feasible in the current mock test setup.
ramahalingam
reviewed
Apr 9, 2021
| @@ -0,0 +1,22 @@ | |||
| package com.hyperwallet.clientsdk.model; | |||
|
|
|||
| import java.util.Date; | |||
There was a problem hiding this comment.
Pls remove this unused import
ramahalingam
reviewed
Apr 9, 2021
| @@ -1334,7 +1376,7 @@ public void uploadUserDocuments_invalidDocumentStatus() throws Exception { | |||
|
|
|||
| // | |||
| // Transfer Refunds | |||
| // | |||
| //f | |||
ramahalingam
reviewed
Apr 9, 2021
| assertThat(userOne.getCreatedOn(), is(equalTo(dateFormat.parse("2019-10-30T22:15:35 UTC")))); | ||
| assertThat(userOne.getStatus(), is(equalTo(HyperwalletUser.Status.PRE_ACTIVATED))); | ||
| assertThat(userOne.getVerificationStatus(), is(equalTo(HyperwalletUser.VerificationStatus.NOT_REQUIRED))); | ||
| } |
There was a problem hiding this comment.
Pls add assert statement for the 2nd index as well.
ramahalingam
reviewed
Apr 9, 2021
| @@ -0,0 +1,80 @@ | |||
| package com.hyperwallet.clientsdk.model; | |||
|
|
|||
| import java.util.Date; | |||
There was a problem hiding this comment.
Pls remove this unused import
ramahalingam
reviewed
Apr 9, 2021
| mockServer.verify(parseRequest(functionality)); | ||
| throw e; | ||
| } | ||
| assertThat(returnValue.getCount(), is(equalTo(2))); |
There was a problem hiding this comment.
Pls add assert statement for the 2nd index as well.
ramahalingam
requested changes
Apr 9, 2021
…element in the users list, deleted .DS_store files
ramahalingam
approved these changes
May 4, 2021
jbausch-hw
approved these changes
May 4, 2021
| @@ -0,0 +1,78 @@ | |||
| package com.hyperwallet.clientsdk.model; | |||
|
|
|||
| public class HyperwalletUsersListPaginationOptions extends HyperwalletPaginationOptions{ | |||
There was a problem hiding this comment.
minor: is your formatter turned on? there should be a space between HyperwalletPaginationOptions and {
| public void setProgramToken(String programToken) { | ||
| this.programToken = programToken; | ||
| } | ||
|
|
peter-joseph
approved these changes
May 4, 2021
arao6
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify and approve this PR for the following change: