This repository is currently being migrated. It's locked while the migration is in progress.
HW-57146 java sdk for transfer refunds #44
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbausch-hw
approved these changes
Nov 12, 2019
Comment on lines
806
to
816
| assertThat(returnValue.getStatus(), is(Status.COMPLETED)); | ||
| assertThat(returnValue.getClientRefundId(), is("1573548663")); | ||
| assertThat(returnValue.getSourceToken(), is("act-ba4e8fdd-614b-11e5-af23-0faa28ca7c0f")); | ||
| assertThat(returnValue.getSourceAmount(), is(50.0)); | ||
| assertThat(returnValue.getSourceCurrency(), is("USD")); | ||
| assertThat(returnValue.getDestinationToken(), is("usr-3deb34a0-ffd1-487d-8860-6d69435cea6c")); | ||
| assertThat(returnValue.getDestinationAmount(), is(50.0)); | ||
| assertThat(returnValue.getDestinationCurrency(), is("USD")); | ||
| assertThat(returnValue.getNotes(), is("Merchant Payment return to Wallet Balance")); | ||
| assertThat(returnValue.getMemo(), is("TransferReturn123456")); | ||
| assertThat(returnValue.getCreatedOn(), is(dateFormat.parse("2019-11-12T11:51:05 UTC"))); |
There was a problem hiding this comment.
Is it possible to extract this to a common re-usable method.
Comment on lines
2906
to
2911
| assertThat(e.getErrorCode(), is(nullValue())); | ||
| assertThat(e.getResponse(), is(nullValue())); | ||
| assertThat(e.getErrorMessage(), is(equalTo("Transfer Refund is required"))); | ||
| assertThat(e.getMessage(), is(equalTo("Transfer Refund is required"))); | ||
| assertThat(e.getHyperwalletErrors(), is(nullValue())); | ||
| assertThat(e.getRelatedResources(), is(nullValue())); |
There was a problem hiding this comment.
Same with this, is it possible to extract this to a common re-usable method.
jbausch-hw
approved these changes
Nov 25, 2019
…/HW-57146_java_sdk_for_transfer_refunds
peter-joseph
deleted the
feature/HW-57146_java_sdk_for_transfer_refunds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.